Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not panic at non-ssh server connections #78

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Do not panic at non-ssh server connections #78

merged 1 commit into from
Oct 13, 2023

Conversation

HsuJv
Copy link
Collaborator

@HsuJv HsuJv commented Oct 13, 2023 •
edited
Loading

This close #77

If we connect to a non-ssh server, which also returns some handshake msgs after the connection setup(e.g. vnc),
The original assert may cuz a panic which is unexpected.

This change is about avoiding panic and logging this case.

BRs

@HsuJv HsuJv merged commit 8eeec25 into 1148118271:main Oct 13, 2023
6 checks passed
@HsuJv HsuJv deleted the patch_77 branch October 13, 2023 00:37
@HsuJv HsuJv mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ssh-rs panic on a thread when using in multi threading
1 participant
@HsuJv